Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build on cuda 11.5 #1277

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

benfred
Copy link
Member

@benfred benfred commented Feb 13, 2023

On CUDA 11.8 raft currently compiles fine, but with CUDA 11.5 I see unused function parameter warnings, which are currently treated as errors and therefore prevents compilation. This PR reenables compilation on 11.5 CUDA versions by removing the unused parameters

@benfred benfred added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 13, 2023
@benfred benfred requested a review from a team as a code owner February 13, 2023 23:33
@benfred benfred marked this pull request as draft February 13, 2023 23:33
@github-actions github-actions bot added the cpp label Feb 13, 2023
@benfred benfred changed the title Attempt to fix build on cuda 11.5 fix build on cuda 11.5 Feb 13, 2023
@benfred benfred marked this pull request as ready for review February 13, 2023 23:49
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benfred
Copy link
Member Author

benfred commented Feb 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7d6e4dc into rapidsai:branch-23.04 Feb 14, 2023
@benfred benfred deleted the fix_cuda_11_5 branch February 14, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants