Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping only compute similarity specializations for uint64_t for now #1255

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 8, 2023

…(to match other specializations)

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 8, 2023
@cjnolet cjnolet self-assigned this Feb 8, 2023
@github-actions github-actions bot added the cpp label Feb 8, 2023
@github-actions github-actions bot added the CMake label Feb 8, 2023
@github-actions github-actions bot removed the CMake label Feb 8, 2023
@cjnolet cjnolet marked this pull request as ready for review February 8, 2023 02:41
@cjnolet cjnolet requested a review from a team as a code owner February 8, 2023 02:41
@codecov-commenter
Copy link

Codecov Report

Base: 87.99% // Head: 87.99% // No change to project coverage 👍

Coverage data is based on head (dfd0ee7) compared to base (bd0d86b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.04    #1255   +/-   ##
=============================================
  Coverage         87.99%   87.99%           
=============================================
  Files                21       21           
  Lines               483      483           
=============================================
  Hits                425      425           
  Misses               58       58           
Impacted Files Coverage Δ
python/pylibraft/pylibraft/cluster/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member Author

cjnolet commented Feb 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit ca34321 into rapidsai:branch-23.04 Feb 8, 2023
rapids-bot bot pushed a commit that referenced this pull request Feb 11, 2023
…declarations (#1272)

A number of template instantiations were removed in #1255, but the corresponding extern declarations appear to have persisted, resulting in any library including those headers ending up with undefined symbols.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants