Forward-merge branch-23.02 to branch-23.04 #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the sparseL2NN functionality. This enables faster computing pairwise distances by making use of sparsity in the problem: the computation of distances between point pairs can be skipped. The sparsity between arrays of points X and Y is expressed as follows: - X is split into rows (points) - Y is split into contiguous groups of points (i.e. all points in a group are adjacent) - A boolean adjacency matrix indicates for each row of X and each group in Y whether to compute the distance. To speed up computation, the adjacency matrix is compressed into a bitfield. To ensure competitive speeds, the caller must make sure that consecutive rows in X are adjacent to the same groups in Y (as much as possible) to enable efficient skipping in the kernel. Some work is still TODO: - Flesh out documentation - Discuss / remove allocation of intermediate array - Optimize for skinny matrices by using a different KernelPolicy. Authors: - Allard Hendriksen (https://github.com/ahendriksen) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) URL: #838
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-23.02that creates a PR to keepbranch-23.04up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.