Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for svd API #1190

Merged
merged 8 commits into from
Feb 4, 2023
Merged

Fix for svd API #1190

merged 8 commits into from
Feb 4, 2023

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jan 26, 2023

No description provided.

@lowener lowener added bug Something isn't working 3 - Ready for Review breaking Breaking change labels Jan 26, 2023
@lowener lowener self-assigned this Jan 26, 2023
@lowener lowener requested a review from a team as a code owner January 26, 2023 15:38
@github-actions github-actions bot added the cpp label Jan 26, 2023
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need a test to verify the nullopt case is working.

cpp/include/raft/linalg/svd.cuh Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@a426bc9). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04    #1190   +/-   ##
===============================================
  Coverage                ?   87.99%           
===============================================
  Files                   ?       21           
  Lines                   ?      483           
  Branches                ?        0           
===============================================
  Hits                    ?      425           
  Misses                  ?       58           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lowener lowener requested a review from cjnolet February 2, 2023 21:48
@cjnolet cjnolet changed the base branch from branch-23.02 to branch-23.04 February 3, 2023 20:28
@cjnolet
Copy link
Member

cjnolet commented Feb 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit bc764b8 into rapidsai:branch-23.04 Feb 4, 2023
@lowener lowener deleted the 23.02-svd-fix branch February 5, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review breaking Breaking change bug Something isn't working cpp
Projects
Development

Successfully merging this pull request may close these issues.

3 participants