Some MST updates for single-linkage / HDBSCAN clustering #119
Conversation
cjnolet
added
enhancement
cjnolet
changed the title
cjnolet
changed the title
|
This PR has been labeled |
| detail::add_reverse_edge<<<nblocks, nthreads, 0, stream>>>( | ||
| new_mst_edge_ptr, indices, weights, temp_src_ptr, temp_dst_ptr, | ||
| temp_weights_ptr, v); | ||
| // detail::add_reverse_edge<<<nblocks, nthreads, 0, stream>>>( |
There was a problem hiding this comment.
An extra comment here to document why this kernel launch is commented
There was a problem hiding this comment.
I had forgotten about this change. @afender, this will probably break cugraph if we remove the symmetry altogether right? Should we make this optional?
There was a problem hiding this comment.
If this is made optional, then the changes to the above additions will also have to be made optional
There was a problem hiding this comment.
Just to make note here- we talked offline about this. @divyegala will push necessary updates directly to this branch (or open a follow-on if necessary). SLHC is dependent upon this change but we can't break cugraph's assumption of symmetric outputs.
The rust api docs on docs.rapids.ai are deployed to https://docs.rapids.ai/api/cuvs/nightly/rust_api/index.html but the relative link in the iframe was assuming that these were at https://docs.rapids.ai/api/cuvs/nightly/rust_api.html. (There seems to be some difference in the url structure depending on whether you build locally or not) Fix by forcing the url structure to always be `rust_api/index.html` Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#119
We may not need this for single-linkage / hdbscan clustering. Not sure yet.