-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to convert mdspan to a const view #1188
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f7382d
Add `make_const_mdspan`
lowener bcdb67f
Add const accessor
lowener 7071cf9
Add examples
lowener a9e090c
Merge branch 'branch-23.02' into 23.02-const-mdspan
lowener 3e3facb
Add doxygen doc
lowener 351b09e
Add `accessor_of_const`
lowener 97aabb7
Merge branch 'branch-23.02' into 23.02-const-mdspan
cjnolet 5bd10a1
Fixing style
cjnolet dd541ae
Update cpp/include/raft/core/mdspan.hpp
lowener 40378bb
Add test for `make_const_mdspan`
lowener File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct way to do it, as long as
host_device_accessor
has an element type converting constructor likedefault_accessor
does (see the first constructor here). A straightforward unit test would fail to compile without that constructor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great point, @mhoemmen. It's nice to see the new function being used in the k-means tests but we should probably have a dedicated testcase for this (ideally in the mdspan cpp test file).