Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs build job #1168

Merged
merged 58 commits into from
Feb 17, 2023
Merged

Add docs build job #1168

merged 58 commits into from
Feb 17, 2023

Conversation

AyodeAwe
Copy link
Contributor

The PR adds a docs_build process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.

@AyodeAwe AyodeAwe added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2023
@github-actions github-actions bot added the ci label Jan 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@f8d3f5b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04    #1168   +/-   ##
===============================================
  Coverage                ?   87.99%           
===============================================
  Files                   ?       21           
  Lines                   ?      483           
  Branches                ?        0           
===============================================
  Hits                    ?      425           
  Misses                  ?       58           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AyodeAwe AyodeAwe marked this pull request as ready for review January 29, 2023 15:55
@AyodeAwe AyodeAwe requested a review from a team as a code owner January 29, 2023 15:55
@AyodeAwe AyodeAwe changed the title add docs_build step Add docs build job Jan 29, 2023
dependencies.yaml Outdated Show resolved Hide resolved
this option is spelled incorrectly and therefore not used by `sphinx`.

the correct configuration options are specified in `conf.py`
according to the `autodoc` docs below, `autodoc` will automatically import the modules to be documented.

this the docs build CI job installs the packages that were previously built in the workflow run, we don't need to modify `sys.path` to include these packages

- https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html
a previous commit updated the `xml` output location for `Doxygen`, so this commit updates the `sphinx` config accordingly
and re-generate dependency files
according to the `sphinx` warnings, these `.rst` files aren't used anywhere
these links were invalid and issuing `sphinx` warnings
@ajschmidt8
Copy link
Member

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 013da20 into rapidsai:branch-23.04 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

4 participants