Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use squeuclidean for metric name in ivf_pq python bindings #1160

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Use squeuclidean for metric name in ivf_pq python bindings #1160

merged 1 commit into from
Jan 20, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Jan 19, 2023

Use sqeuclidean instead of l2_expanded for the distance name in the ivf_pq python bindings. This matches both sklearn, and the RAFT pairwise_distance api - and should be less confusing for our users

@benfred
Use squeuclidean for metric name in ivf_pq python bindings
9183aec 
Use sqeuclidean instead of l2_expanded for the distance name in the
ivf_pq python bindings. This matches both sklearn, and the RAFT
pairwise_distance api - and should be less confusing for our users
@benfred benfred requested a review from a team as a code owner January 19, 2023 22:29
@benfred benfred mentioned this pull request Jan 19, 2023
Merged
@benfred benfred added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 19, 2023
cjnolet
cjnolet approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benfred
Copy link
Member Author

benfred commented Jan 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit d233a2c into rapidsai:branch-23.02 Jan 20, 2023
@benfred benfred deleted the ivfpq_sqeuclidean branch January 20, 2023 03:34
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Jan 23, 2023
@benfred @ahendriksen
Use squeuclidean for metric name in ivf_pq python bindings (rapidsai#…
165e940 
…1160)

Use sqeuclidean instead of l2_expanded for the distance name in the ivf_pq python bindings. This matches both sklearn, and the RAFT pairwise_distance api - and should be less confusing for our users

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#1160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfred @cjnolet