Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cutlass use static ctk #1155

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Make cutlass use static ctk #1155

merged 1 commit into from
Jan 20, 2023

Conversation

sevagh
Copy link
Contributor

@sevagh sevagh commented Jan 18, 2023

Cutlass links to the CTK in ways that cause problems for downstream pip wheel builds (especially in cugraph).

This might help.

@sevagh sevagh requested a review from a team as a code owner January 18, 2023 22:11
@sevagh
Copy link
Contributor Author

sevagh commented Jan 18, 2023

I used this branch (pull-request/1155) in the cugraph PR's PINNED_TAG for raft: rapidsai/cugraph#3096

That's the wheel (likely) suffering from this cutlass problem because it ends up without libcusolver symbols and fails to work.

Hopefully we can see cugraph go green as a result

@codecov-commenter
Copy link

Codecov Report

Base: 87.99% // Head: 87.99% // No change to project coverage 👍

Coverage data is based on head (52337f9) compared to base (efd42c9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #1155   +/-   ##
=============================================
  Coverage         87.99%   87.99%           
=============================================
  Files                21       21           
  Lines               483      483           
=============================================
  Hits                425      425           
  Misses               58       58           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 19, 2023
@cjnolet
Copy link
Member

cjnolet commented Jan 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit 102a4f0 into rapidsai:branch-23.02 Jan 20, 2023
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Jan 23, 2023
Cutlass links to the CTK in ways that cause problems for downstream pip wheel builds (especially in cugraph).

This might help.

Authors:
  - Sevag H (https://github.com/sevagh)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants