Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raft::void_op functor #1136

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Add raft::void_op functor #1136

merged 2 commits into from
Jan 12, 2023

Conversation

ahendriksen
Copy link
Contributor

@ahendriksen ahendriksen commented Jan 11, 2023 •
edited
Loading

Follow up on PR #1049. Adds a void_op functor for lambdas that are unused.

@ahendriksen ahendriksen requested a review from a team as a code owner January 11, 2023 17:17
@github-actions github-actions bot added the cpp label Jan 11, 2023
@ahendriksen ahendriksen added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2023
@ahendriksen
Add raft::no_op functor
f95f976 
This makes it easier to see if a lambda is unused.
@ahendriksen ahendriksen force-pushed the enh-add-no-op-functor branch from 1445a6b to f95f976 Compare January 11, 2023 17:27
Nyrio
Nyrio reviewed Jan 11, 2023
View reviewed changes
cpp/include/raft/core/operators.hpp Outdated Show resolved Hide resolved
cpp/include/raft/core/operators.hpp Outdated Show resolved Hide resolved
achirkin
achirkin requested changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! One thing regarding the implementation below

cpp/include/raft/core/operators.hpp Outdated Show resolved Hide resolved
@ahendriksen ahendriksen changed the title Add raft::no_op functor Add raft::void_op functor Jan 11, 2023
@cjnolet
Copy link
Member

cjnolet commented Jan 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit bbe0755 into rapidsai:branch-23.02 Jan 12, 2023
@ahendriksen ahendriksen deleted the enh-add-no-op-functor branch March 17, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyrio Nyrio Nyrio approved these changes

@achirkin achirkin achirkin approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@ahendriksen ahendriksen

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahendriksen @cjnolet @achirkin @Nyrio