Cleanup faiss includes #1098
Merged
Cleanup faiss includes #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly removes un-needed faiss includes - but also removes the `KeyValueWarpSelect` function which isn't being used anywhere, and replaces faiss::gpu::KeyValuePair with cub::KeyValuePair
benfred
added
improvement
cjnolet
approved these changes
Dec 14, 2022
| return (value != b.value) || (key != b.key); | ||
| } | ||
| }; | ||
| using cub::KeyValuePair; |
There was a problem hiding this comment.
Doesn't need to hold up this PR but it would be nice to use raft::KeyValuePair here for consistency. I've been converting the cub::keyvaluepair to the raft version everywhere for consistency except where the cub version is absolutely necessary.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly removes un-needed faiss includes - but also removes the
KeyValueWarpSelectfunction which isn't being used anywhere, and replacesfaiss::gpu::KeyValuePairwithcub::KeyValuePairin warp_select_faiss.cuh