Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in raft::random::discrete #1094

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix race condition in raft::random::discrete #1094

merged 1 commit into from
Dec 13, 2022

Conversation

Nyrio
Copy link
Contributor

@Nyrio Nyrio commented Dec 13, 2022

The stream needs to be passed to cub::DeviceScan.

@Nyrio Nyrio requested a review from a team as a code owner December 13, 2022 13:09
@github-actions github-actions bot added the cpp label Dec 13, 2022
@Nyrio Nyrio added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Dec 13, 2022
cjnolet
cjnolet approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nyrio Nyrio changed the title Solve race condition in raft::random::discrete Fix race condition in raft::random::discrete Dec 13, 2022
@cjnolet
Copy link
Member

cjnolet commented Dec 13, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Dec 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 057fb37 into rapidsai:branch-23.02 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@Nyrio Nyrio

Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyrio @cjnolet