Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Fix pinnings for dask. #1082

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 8, 2022

The pip package pinnings were missed in #1062.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Dec 8, 2022
@vyasr vyasr self-assigned this Dec 8, 2022
@vyasr vyasr requested a review from a team as a code owner December 8, 2022 20:58
@github-actions github-actions bot added the python label Dec 8, 2022
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks for updating!

(btw, I have a PR #1083 to update the codespell settings to ignore the changelog because of the initial failure here)

@cjnolet cjnolet changed the title Fix pinnings for dask. [HOTFIX] Fix pinnings for dask. Dec 8, 2022
@@ -26,10 +26,10 @@
"numpy",
"numba>=0.49",
"joblib>=0.11",
"dask-cuda>=22.10",
"dask>=2022.9.1",
"dask-cuda==22.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add this to release version upgrade script at https://github.com/rapidsai/raft/blob/bd2fa8ade237613c769aaf26489a7bf49b353d8c/ci/release/update-version.sh

Though this can be done in 23.02, should be good to merge this PR once @cjnolet approves.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raydouglass raydouglass merged commit 23c9b15 into rapidsai:branch-22.12 Dec 13, 2022
@vyasr vyasr deleted the raft_dask_pinning branch December 13, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

5 participants