Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions Workflows. #1076

Merged
merged 52 commits into from
Dec 21, 2022
Merged

Add GitHub Actions Workflows. #1076

merged 52 commits into from
Dec 21, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 7, 2022

This PR adds GitHub Actions workflows to raft.

Wait until after the 22.12 release is complete (and potentially until other repos are ready to migrate to GHA) to merge.

Task list

Coverage required for this PR:

  • C++ tests
    • Two test failures on ARM? Result/18: SWoRTests/SWoRTestD; /opt/conda/conda-bld/work/cpp/test/random/sample_without_replacement.cu:269
  • Python tests
  • Codecov
  • Style checks

Future work:

@github-actions github-actions bot added the gpuCI label Dec 7, 2022
@bdice bdice changed the title Add GitHub Actions Workflows. Add GitHub Actions Workflows. [skip gpuci] Dec 7, 2022
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 12, 2022
ci/check_style.sh Outdated Show resolved Hide resolved
rapids-bot bot pushed a commit that referenced this pull request Dec 17, 2022
The sample-without-replacement test fails on A100 when `largeWeight` parameter is enabled, observed in PR #1076. The failure is caused as the sample with largest weight might not always be the first element getting selected in the sampled array. To fix this issue, this PR proposes to search the sample with large weight in the first three elements of sampled array.

Authors:
  - Vinay Deshpande (https://github.com/vinaydes)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #1109
ajschmidt8 and others added 19 commits December 16, 2022 22:03
`raft` doesn't have notebooks anyway
the `11.4.x` `cuda-profiler-api` package is only available for `aarch64`.

therefore, this commit increases the upper limit of the version specifier for this package to avoid conda solver issues.
…ages

This is to ensure that the other `raft` packages get built with the correct `libcu*` versioned packages.

This commit also alphabetizes the lists.
this commit updates `dependencies.yaml` to:

- include both `-dev` and non `-dev` packages of the `libcu*` packages
- use a version range instead of a specific version pin for the `libcu*` packages
this moves `11.2` after `11.4` so that the `11.4` YAML anchors work with `11.2`
@bdice bdice changed the title Add GitHub Actions Workflows. [skip gpuci] Add GitHub Actions Workflows. Dec 20, 2022
@bdice
Copy link
Contributor Author

bdice commented Dec 20, 2022

rerun tests

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I compared the old scripts and recipes w/ the new scripts and everything looks good to me.

When you guys are ready, I can help split the dependencies.yml apart for the different recipes.

@bdice
Copy link
Contributor Author

bdice commented Dec 20, 2022

When you guys are ready, I can help split the dependencies.yml apart for the different recipes.

I think we'll be ready for that after this PR merges. Thanks again!

@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 107f6e3 into rapidsai:branch-23.02 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

4 participants