-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paying down some tech debt on docs, runtime API, and cython #1055
Merged
rapids-bot
merged 39 commits into
rapidsai:branch-23.02
from
cjnolet:doc-2212-remove_broken_docs
Dec 6, 2022
Merged
Paying down some tech debt on docs, runtime API, and cython #1055
rapids-bot
merged 39 commits into
rapidsai:branch-23.02
from
cjnolet:doc-2212-remove_broken_docs
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! I'm liking how much more fleshed out the docs will be here -
Co-authored-by: Ben Frederickson <[email protected]>
Co-authored-by: Ben Frederickson <[email protected]>
… into doc-2212-remove_broken_docs
cjnolet
changed the title
Follow-on fixes for docs
Paying down some tech debt on docs, runtime API, and cython
Dec 3, 2022
divyegala
approved these changes
Dec 5, 2022
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pays down some tech debt and cleans up some things. On the surface, you'll notice many files have been touched or modified but the modifications are largely confined to a few major categories of changes:
Fixes some of the issues found with the doc updates in 22.12.
Breaks some of the docs for the c++ namespaces down into multiple sections to make them easier to navigate and consume
Renames raft_distance directory into more appropriately named raft_runtime. (This is also in preparation to eventually rename the libraft-distance library into libraft once we can remove the FAISS dependency.
Separates out some runtime source files and APIs that were being mistakenly combined with the template specializations API
Consolidates multiple mdspan.pxd files into a single file.
Consistently uses
cpp
directory for new(er) pxd files, nested into their respective packages.Consistently uses doxygen groups in many of the namespaces.