Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fusedL2NN: Add input alignment checks #1045

Merged
merged 1 commit into from
Nov 23, 2022
Merged

fusedL2NN: Add input alignment checks #1045

merged 1 commit into from
Nov 23, 2022

Conversation

achirkin
Copy link
Contributor

Add an extra check for the alignment of the input matrices to avoid misaligned address errors.

@achirkin achirkin requested a review from a team as a code owner November 23, 2022 15:48
@github-actions github-actions bot added the cpp label Nov 23, 2022
@achirkin achirkin added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change cpp and removed cpp labels Nov 23, 2022
@achirkin
Copy link
Contributor Author

NB: I encountered this trying to use the address given by the host mmap + cudaHostRegister (which was 8-byte aligned, not 16).

cjnolet
cjnolet approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Nov 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8162565 into rapidsai:branch-22.12 Nov 23, 2022
@achirkin achirkin deleted the fix-fused-l2nn-unaligned-input branch November 24, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achirkin @cjnolet