Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IVF-PQ: use device properties helper #1035

Merged
merged 1 commit into from
Nov 18, 2022
Merged

IVF-PQ: use device properties helper #1035

merged 1 commit into from
Nov 18, 2022

Conversation

achirkin
Copy link
Contributor

Use raft handle's lazy-loading helper get_device_properties instead of explicitly calling cudaGetDeviceProperties on every kernel launch, which is a costly operation.

@achirkin achirkin requested a review from a team as a code owner November 18, 2022 10:36
@github-actions github-actions bot added the cpp label Nov 18, 2022
@achirkin achirkin added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 18, 2022
tfeher
tfeher approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement, LGTM!

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d6df557 into rapidsai:branch-22.12 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achirkin @cjnolet @tfeher