-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Change raft
docs theme to pydata-sphinx-theme
#1026
Conversation
Hey @galipremsagar, I really like this theme overall. I think the top headings fit perfectly in place as well. I notice the |
@cjnolet Is this the Distance API you are referring to? Attached is my local clean install build for html folder just incase : raft_build.zip |
Ah, got it. I can see the issue. Working on it |
@cjnolet This should be fixed now: Build zip: raft_docs_build.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @galipremsagar!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this PR intended to include changes to build.sh
? From the PR title and description, I thought these changes would just be related to the docs theme
So, when building locally we discovered |
@gpucibot merge |
Arg, I hate weird failures. I just realized the conda recipe build scripts need to be updated (they were using the --install flag) |
It should now be fixed, Apologies for the oversight |
@gpucibot merge |
Similar to rapidsai/cuml#4985, this PR changes the docs theme for
raft
to be in-line with rest of the rapids docs theme.