Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Change raft docs theme to pydata-sphinx-theme #1026

Merged
merged 7 commits into from
Nov 18, 2022

Conversation

galipremsagar
Copy link
Contributor

Similar to rapidsai/cuml#4985, this PR changes the docs theme for raft to be in-line with rest of the rapids docs theme.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 17, 2022
@cjnolet
Copy link
Member

cjnolet commented Nov 17, 2022

Hey @galipremsagar, I really like this theme overall. I think the top headings fit perfectly in place as well.

I notice the pylibraft distance docs don't seem to be rendered the code example, at least for me, but that example is rendering fine in the nightlies.

@galipremsagar
Copy link
Contributor Author

@cjnolet Is this the Distance API you are referring to?

Screen Shot 2022-11-17 at 2 24 13 PM

Attached is my local clean install build for html folder just incase : raft_build.zip

@galipremsagar
Copy link
Contributor Author

Ah, got it. I can see the issue. Working on it

@galipremsagar galipremsagar requested review from a team as code owners November 17, 2022 21:56
@galipremsagar
Copy link
Contributor Author

@cjnolet This should be fixed now:

Screen Shot 2022-11-17 at 3 57 43 PM

Build zip: raft_docs_build.zip

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @galipremsagar!

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR intended to include changes to build.sh? From the PR title and description, I thought these changes would just be related to the docs theme

@galipremsagar
Copy link
Contributor Author

is this PR intended to include changes to build.sh? From the PR title and description, I thought these changes would just be related to the docs theme

So, when building locally we discovered build.sh needed changes for a successful local build. Hence packed the changes into this PR.

@cjnolet
Copy link
Member

cjnolet commented Nov 17, 2022

@gpucibot merge

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2022

Arg, I hate weird failures. I just realized the conda recipe build scripts need to be updated (they were using the --install flag)

@galipremsagar
Copy link
Contributor Author

Arg, I hate weird failures. I just realized the conda recipe build scripts need to be updated (they were using the --install flag)

It should now be fixed, Apologies for the oversight

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2022

@gpucibot merge

@github-actions github-actions bot added the gpuCI label Nov 18, 2022
@rapids-bot rapids-bot bot merged commit 5a00013 into rapidsai:branch-22.12 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

3 participants