Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Move the new select-top-k code to the matrix namespace #853

Closed
achirkin opened this issue Sep 28, 2022 · 0 comments · Fixed by #1085
Closed

[FEA] Move the new select-top-k code to the matrix namespace #853

achirkin opened this issue Sep 28, 2022 · 0 comments · Fixed by #1085
Assignees
@achirkin
Labels
feature request New feature or request

Comments

@achirkin
Copy link
Contributor

A new, handy wrapper code top-k emerged in #789 . There were suggestions to move it to the public raft::matrix namespace.
Besides that, I'd like to:

  1. Deprecate the old top-k api.
  2. Add specializations for the templates into the raft NN library component for faster parallel compile times.
@achirkin achirkin added the feature request New feature or request label Sep 28, 2022
This was referenced Sep 28, 2022
Merged
Merged
@achirkin achirkin mentioned this issue Dec 9, 2022
Merged
@cjnolet cjnolet mentioned this issue Jan 10, 2023
Closed
@achirkin achirkin self-assigned this Jan 11, 2023
rapids-bot bot pushed a commit that referenced this issue Jan 23, 2023
@achirkin
matrix::select_k: move selection and warp-sort primitives (#1085)
0076101 
Refactor and move a set of implementations for batch-selecting top K largest/smallest values:

  - Move device warp-wide primitives `bitonic_sort.cuh` to the public `raft::util` namespace, add tests.
  - Create a new public `matrix::select_k` interface.
  - Deprecate the legacy public `raft::spatial::knn::select_k` interface.
  - Copy/adapt `select_k` tests.
  - Move/adapt `select_k` benchmarks.
  - Rework the internals of `select_warpsort.cuh` to enable more implementations.

Closes #853

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1085
@github-project-automation github-project-automation bot moved this from In Progress to Done in VS/ML/DM Primitives Release Board Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achirkin achirkin

Labels
feature request New feature or request
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

matrix::select_k: move selection and warp-sort primitives achirkin/raft
1 participant
@achirkin