Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Separate device_mdspan and host_mdspan from mdarray.hpp into device_mdspan.hpp and host_mdspan.hpp #806

Closed
cjnolet opened this issue Sep 6, 2022 · 0 comments · Fixed by #810
Closed

[FEA] Separate device_mdspan and host_mdspan from mdarray.hpp into device_mdspan.hpp and host_mdspan.hpp #806

cjnolet opened this issue Sep 6, 2022 · 0 comments · Fixed by #810
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Sep 6, 2022

We are doing this for the purpose of 1) making the includes more specific to mdspan (rather than putting everything in mdarray.hpp as they are currently, and 2) allowing the host_mdspan to be included and used without ever having to know anything about CUDA (meaning it can be compiled with gcc and doesn't require any runtime libs or headers).

It's also important the corresponding accessors be moved into these files.
@cjnolet cjnolet added the feature request New feature or request label Sep 6, 2022
This was referenced Sep 7, 2022
Merged
Open
@rapids-bot rapids-bot bot closed this as completed in #810 Sep 22, 2022
rapids-bot bot pushed a commit that referenced this issue Sep 22, 2022
@cjnolet
Separating mdspan/mdarray infra into host_* and device_* variants (#810)
6a1d1da 
This is a breaking change as it provides users with a more granular set of headers to import `host` separately from `device` and `managed` versions. It also separates the headers for `mdspan` and `mdarray`. 

As an example, the following public headers can now be imported individually:
```c++
raft/core/host_mdspan.hpp
raft/core/device_mdspan.hpp

raft/core/host_mdarray.hpp
raft/core/device_mdarray.hpp
```


cc @rg20 @afender @akifcorduk for awareness. 


Closes #806

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Mark Hoemmen (https://github.com/mhoemmen)
  - William Hicks (https://github.com/wphicks)

URL: #810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separating mdspan/mdarray infra into host_* and device_* variants cjnolet/raft
1 participant
@cjnolet