Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Expose raft::linalg::dot through public API #805

Closed
cjnolet opened this issue Sep 6, 2022 · 1 comment · Fixed by #968
Closed

[FEA] Expose raft::linalg::dot through public API #805

cjnolet opened this issue Sep 6, 2022 · 1 comment · Fixed by #968
Assignees
@benfred
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Sep 6, 2022

Currently, the cublas dot() API is being hidden in detail but this is something that would be useful to expose through our linear algebra public API functions to facade users downstream away from the implementations and provide them a more consistent API vocabulary.

We should wrap the cublas dot() functions in the raft::linalg namespace.

cc @akifcorduk @katrinescheel
@cjnolet cjnolet added the feature request New feature or request label Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@benfred benfred self-assigned this Oct 31, 2022
benfred added a commit to benfred/raft that referenced this issue Oct 31, 2022
@benfred
Expose linalg::dot in public API
01dd067 
Closes rapidsai#805
@benfred benfred mentioned this issue Oct 31, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in #968 Nov 10, 2022
rapids-bot bot pushed a commit that referenced this issue Nov 10, 2022
@benfred
Expose linalg::dot in public API (#968)
7176d94 
Closes #805

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #968
Repository owner moved this from In Progress to Done in VS/ML/DM Primitives Release Board Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benfred benfred

Labels
feature request New feature or request
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose linalg::dot in public API benfred/raft
2 participants
@benfred @cjnolet