Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Optimize span class with static extent #511

Closed
trivialfis opened this issue Feb 16, 2022 · 3 comments · Fixed by #515
Closed

[FEA] Optimize span class with static extent #511

trivialfis opened this issue Feb 16, 2022 · 3 comments · Fixed by #515
Labels
feature request New feature or request

Comments

@trivialfis
Copy link
Member

trivialfis commented Feb 16, 2022 •
edited
Loading

As suggested by @jrhemstad in #399 (comment) we can make sure the compiler knows when to remove the size variable by specializing over static/dynamic extent for the span class.
@trivialfis trivialfis added the feature request New feature or request label Feb 16, 2022
@trivialfis trivialfis mentioned this issue Feb 16, 2022
Merged
@jakirkham
Copy link
Member

Maybe meant @jrhemstad ?

@trivialfis
Copy link
Member Author

Oops, sorry! Thank you for pointing that out.

@jakirkham
Copy link
Member

No worries 🙂

@trivialfis trivialfis mentioned this issue Feb 17, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in #515 Feb 18, 2022
rapids-bot bot pushed a commit that referenced this issue Feb 18, 2022
@trivialfis
Implement span storage optimization. (#515)
1409002 
Close #511 .

Authors:
  - Jiaming Yuan (https://github.com/trivialfis)

Approvers:
  - Jake Hemstad (https://github.com/jrhemstad)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Implement span storage optimization. trivialfis/raft
2 participants
@jakirkham @trivialfis