Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QST] Question about VectorSearch_QuestionRetrieval.ipynb #2230

Closed
hdeep03 opened this issue Mar 18, 2024 · 1 comment · Fixed by #2231
Closed

[QST] Question about VectorSearch_QuestionRetrieval.ipynb #2230

hdeep03 opened this issue Mar 18, 2024 · 1 comment · Fixed by #2231
Labels
question Further information is requested

Comments

@hdeep03
Copy link

hdeep03 commented Mar 18, 2024

What is your question?

In the last cell of the VectorSearch_QuestionRetrieval.ipynb notebook, it runs %time which only times the current line(which is empty), should it instead run the %%time magic command to actually time the search, or is the performance result from that cell real?
@hdeep03 hdeep03 added the question Further information is requested label Mar 18, 2024
@lowener lowener mentioned this issue Mar 18, 2024
Merged
@lowener
Copy link
Contributor

lowener commented Mar 18, 2024

Good catch, I created PR #2231 to fix this mistake

@rapids-bot rapids-bot bot closed this as completed in #2231 Apr 4, 2024
rapids-bot bot pushed a commit that referenced this issue Apr 4, 2024
@lowener
Fix time computation in CAGRA notebook (#2231)
8a68518 
Closes #2230.
I am also adding `nn_descent` to the build parameters of cagra

Authors:
  - Micka (https://github.com/lowener)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #2231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix time computation in CAGRA notebook lowener/raft
2 participants
@lowener @hdeep03