[BUG] Stats kernels invalid access #2204
Assignees
Labels
bug
Something isn't working
Comments
rapids-bot bot
pushed a commit
that referenced
this issue
Mar 16, 2024
This PR addresses #2204 and #2205. * fixes illegal access / test coverage for mean row-wise kernel * fixes illegal access / test coverage for stdev row-wise kernel * modified sum kernels to utilize Kahan/Neumaier summation per thread, also increase load per thread to benefit from this FYI, @tfeher Authors: - Malte Förster (https://github.com/mfoerste4) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: #2223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Similar to #2183, the mean and stdev kernels have also potential out of bounds access
https://github.com/rapidsai/raft/blob/branch-24.04/cpp/include/raft/stats/detail/stddev.cuh#L48
https://github.com/rapidsai/raft/blob/branch-24.04/cpp/include/raft/stats/detail/mean.cuh#L46
Additionally the minmax kernel should be also checked, whether it has a similar problem.
Steps/Code to reproduce bug
compute-sanitizer gtests/STATS_TEST. Without compute-sanitizer the test could silently pass.Additional context
The text was updated successfully, but these errors were encountered: