Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add FAISS cpu indexes to raft-ann-bench #1813

Closed
cjnolet opened this issue Sep 10, 2023 · 0 comments · Fixed by #1814
Closed

[FEA] Add FAISS cpu indexes to raft-ann-bench #1813

cjnolet opened this issue Sep 10, 2023 · 0 comments · Fixed by #1814
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Sep 10, 2023

Adding the cpu index types for FAISS is fairly straightforward but what becomes challenging is building the faiss targets for both gpu and cpu-only environments since the cmake build targets automatically pass through the linking to the faiss gpu lib.

Still unclear of a good way to handle this but tagging @robertmaynard for thoughts.
@cjnolet cjnolet added the feature request New feature or request label Sep 10, 2023
@cjnolet cjnolet mentioned this issue Sep 11, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Oct 10, 2023
@cjnolet
Adding FAISS cpu to raft-ann-bench (#1814)
99ed345 
Closes #1813

This PR adds FAISS CPU indexes to the raft-Ann-bench benchmarks, and adjusts the build accordingly. In addition, this PR also updated the FAISS version to include the RAFT-enabled version, which required removing the FAISS conda packages and building FAISS from source.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Robert Maynard (https://github.com/robertmaynard)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding FAISS cpu to raft-ann-bench cjnolet/raft
1 participant
@cjnolet