Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ivf_pq::search mr argument ignored #1558

Open
tfeher opened this issue May 30, 2023 · 0 comments
Open

[BUG] ivf_pq::search mr argument ignored #1558

tfeher opened this issue May 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@tfeher
Copy link
Contributor

tfeher commented May 30, 2023

Describe the bug
The IVF-PQ method has an argument to specify memor allocator used for temporary buffers. https://github.com/rapidsai/raft/blob/branch-23.08/cpp/include/raft/neighbors/ivf_pq-inl.cuh#L407

This allocator is ignored for some of the internal allocations (See #1557), and that decreases the performance.

Expected behavior

We plan to deprecate explicit MR argument for IVF-PQ search. Ideally the workspace allocator shall control the temporary allocations.

Workaround

rmm::mr::pool_memory_resource<rmm::mr::device_memory_resource> mr(rmm::mr::get_current_device_resource(), 1024 * 1024 * 1024ull);
rmm::mr::set_current_device_resource(&mr);
ivf_pq::search(res, search_params, index, queries, neighbors_view, distances_view);
@tfeher tfeher added the bug Something isn't working label May 30, 2023
@tfeher tfeher changed the title [BUG] IVF-PQ mr argument ignored [BUG] ivf_pq::search mr argument ignored May 30, 2023
rapids-bot bot pushed a commit that referenced this issue Jun 30, 2023
This PR fixes perf issues by #1558

Authors:
  - Tamas Bela Feher (https://github.com/tfeher)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant