-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Support non-fused k-selection in IVF-flat #1555
Comments
Linking this to #711, converting this to a feature request, and tagging @achirkin to provide details Im likely to miss- the problem here is that ivf-pq supports both fused and non-fused k-selection (and so is able to support very large settings of k) while ivf-flat on supports the fused k-selection. The need here is to implement non-fused k-selection in ivf-flat so that we can support larger values of k. |
k=256
As @cjnolet aptly specified in the new title, the issue is that IVF-flat implementation relies on Following the IVF-PQ example, I think the scope of the work can (mostly) be limited to a single file
|
Add support for topk > 256 for ivf_flat (Issue [#1555](#1555)) The PR adds a non-fused version of topk that is utilized if k > 256. FYI, @tfeher Authors: - Malte Förster (https://github.com/mfoerste4) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) URL: #2169
raft/cpp/include/raft/matrix/detail/select_warpsort.cuh
Line 100 in 99655ea
raft/cpp/include/raft/neighbors/detail/ivf_flat_interleaved_scan-inl.cuh
Lines 1003 to 1008 in 99655ea
Providing a fallback when
k>256
would be useful.The text was updated successfully, but these errors were encountered: