Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Misleading signature of ivf_pq::search #1357

Closed
achirkin opened this issue Mar 20, 2023 · 0 comments · Fixed by #1539
Closed

[BUG] Misleading signature of ivf_pq::search #1357

achirkin opened this issue Mar 20, 2023 · 0 comments · Fixed by #1539
Labels
bug Something isn't working

Comments

@achirkin
Copy link
Contributor

The raw pointer interface and internals of ivf_pq::search support only up to uint32_t number of queries, probes, k, and dimensionality. Yet, the new mdspan api uses IdxT for the extents. I suggest to change that to uint32_t (the second (index) parameter of every mdspan).
@achirkin achirkin added the bug Something isn't working label Mar 20, 2023
This was referenced May 19, 2023
Merged
Merged
rapids-bot bot pushed a commit that referenced this issue May 20, 2023
@achirkin
ivf-pq::search: fix the indexing type of the query-related mdspan arg…
a196645 
…uments (#1539)

closes #1357

breaking change: the type of argument mdspans has slightly changed (second template parameter fixed to `uint32_t`)

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ivf-pq::search: fix the indexing type of the query-related mdspan arguments achirkin/raft
1 participant
@achirkin