Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Have pairwisedistancebase take a distance_op instead of two lambdas #1323

Closed
ahendriksen opened this issue Mar 9, 2023 · 1 comment
Closed

[FEA] Have pairwisedistancebase take a distance_op instead of two lambdas #1323

ahendriksen opened this issue Mar 9, 2023 · 1 comment
Labels
feature request New feature or request

Comments

@ahendriksen
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Code cleanup: PR #1142 introduced distance operations. They are now wrapped in lambdas before being passed to PairwiseDistanceBase, preserving the original API for PairwiseDistanceBase.

Describe the solution you'd like
It would be cleaner if PairwiseDistanceBase took the distance operations as an argument directly.

#1142 (comment)
@ahendriksen ahendriksen added the feature request New feature or request label Mar 9, 2023
@ahendriksen ahendriksen mentioned this issue Mar 9, 2023
Merged
4 tasks
ahendriksen added a commit to ahendriksen/raft that referenced this issue Mar 14, 2023
@ahendriksen
Take distance_op in pairwise_distance_base
2621306 
Fixes issue rapidsai#1323
ahendriksen added a commit to ahendriksen/raft that referenced this issue Mar 14, 2023
@ahendriksen
Take distance_op in pairwise_distance_base
02acef6 
Fixes issue rapidsai#1323
ahendriksen added a commit to ahendriksen/raft that referenced this issue Mar 15, 2023
@ahendriksen
Take distance_op in pairwise_distance_base
14a9477 
Fixes issue rapidsai#1323
@ahendriksen
Copy link
Contributor Author

Fixed in #1307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahendriksen