Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Remove gtest dependency from benchmark #1153

Closed
hcho3 opened this issue Jan 18, 2023 · 0 comments · Fixed by #1162
Closed

[ENH] Remove gtest dependency from benchmark #1153

hcho3 opened this issue Jan 18, 2023 · 0 comments · Fixed by #1162

Comments

@hcho3
Copy link
Contributor

hcho3 commented Jan 18, 2023

In #1152, we found out that the benchmark suite has an implicit dependency on gtest. We should pull out shared bits of gtest and benchmark into separate headers, so that the benchmark binary doesn't depend on gtest.
@hcho3 hcho3 mentioned this issue Jan 18, 2023
Merged
@cjnolet cjnolet mentioned this issue Jan 19, 2023
Merged
@achirkin achirkin mentioned this issue Jan 23, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Jan 26, 2023
@achirkin
Internal library to share headers between test and bench (#1162)
92820d5 
Add a new component to raft for headers, which are used in both tests and benchmarks.

Closes #1153

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Internal library to share headers between test and bench achirkin/raft
1 participant
@hcho3