Skip to content

Commit

Permalink
Use unanchored clang-format version check (#573)
Browse files Browse the repository at this point in the history
`clang-format -version` installed with apt on Ubuntu reports `Ubuntu clang-format version 11.0.0-2~ubuntu20.04.1`, so we need an unanchored search here.

(Equivalent to rapidsai/cuml@dafcd6f.)

Authors:
  - Zach Bjornson (https://github.com/zbjornson)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #573
  • Loading branch information
zbjornson authored Mar 22, 2022
1 parent 15eb20a commit ebc4feb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpp/scripts/run-clang-format.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020, NVIDIA CORPORATION.
# Copyright (c) 2020-2022, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -64,7 +64,7 @@ def parse_args():
args.dstdir = tempfile.mkdtemp()
ret = subprocess.check_output("%s --version" % args.exe, shell=True)
ret = ret.decode("utf-8")
version = VERSION_REGEX.match(ret)
version = VERSION_REGEX.search(ret)
if version is None:
raise Exception("Failed to figure out clang-format version!")
version = version.group(1)
Expand Down

0 comments on commit ebc4feb

Please sign in to comment.