Skip to content

Commit

Permalink
Remove unnecessary dataset path check in ANN bench (#1908)
Browse files Browse the repository at this point in the history
This PR removes a superfluous path check. This check is not necessary, since the actual dataset path is computed differently (see `legacy_result_folder`), using the path field in the config file. 

The existing test ties the dataset file name to the config file name, therefore imposes an unnecessary restriction. In practice I often have multiple json configs using the same dataset dir.

Authors:
  - Tamas Bela Feher (https://github.com/tfeher)

Approvers:
  - Ben Frederickson (https://github.com/benfred)

URL: #1908
  • Loading branch information
tfeher authored Oct 18, 2023
1 parent 50a9081 commit eb96fc6
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions python/raft-ann-bench/src/raft-ann-bench/run/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@ def main():
dataset_path = args.dataset_path
if not os.path.exists(conf_filepath):
raise FileNotFoundError(conf_filename)
if not os.path.exists(os.path.join(args.dataset_path, dataset_name)):
raise FileNotFoundError(os.path.join(args.dataset_path, dataset_name))

with open(conf_filepath, "r") as f:
conf_file = json.load(f)
Expand Down

0 comments on commit eb96fc6

Please sign in to comment.