Skip to content

Commit

Permalink
Removing cuda stream view include from mdarray (#1429)
Browse files Browse the repository at this point in the history
cc @wphicks

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Divye Gala (https://github.com/divyegala)

URL: #1429
  • Loading branch information
cjnolet authored Apr 18, 2023
1 parent 5d68c57 commit b193956
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions cpp/include/raft/core/mdarray.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
#include <raft/core/mdspan.hpp>
#include <raft/core/mdspan_types.hpp>
#include <raft/core/memory_type.hpp>
#include <rmm/cuda_stream_view.hpp>

namespace raft {
/**
Expand All @@ -45,11 +44,11 @@ namespace raft {
template <typename Base>
class array_interface {
/**
* @brief Get a mdspan that can be passed down to CUDA kernels.
* @brief Get an mdspan
*/
auto view() noexcept { return static_cast<Base*>(this)->view(); }
/**
* @brief Get a mdspan that can be passed down to CUDA kernels.
* @brief Get an mdspan<const T>
*/
auto view() const noexcept { return static_cast<Base*>(this)->view(); }
};
Expand Down Expand Up @@ -108,7 +107,8 @@ inline constexpr bool is_array_interface_v = is_array_interface<Tn...>::value;
* template.
*
* - Most of the constructors from the reference implementation is removed to make sure
* CUDA stream is honorred.
* CUDA stream is honored. Note that this class is not coupled to CUDA and therefore
* will only be used in the case where the device variant is used.
*
* - unique_size is not implemented, which is still working in progress in the proposal
*
Expand Down Expand Up @@ -220,11 +220,11 @@ class mdarray
#undef RAFT_MDARRAY_CTOR_CONSTEXPR

/**
* @brief Get a mdspan that can be passed down to CUDA kernels.
* @brief Get an mdspan
*/
auto view() noexcept { return view_type(c_.data(), map_, cp_.make_accessor_policy()); }
/**
* @brief Get a mdspan that can be passed down to CUDA kernels.
* @brief Get an mdspan<const T>
*/
auto view() const noexcept
{
Expand Down

0 comments on commit b193956

Please sign in to comment.