Skip to content

Commit

Permalink
Disabling expanded fused l2 knn to unblock cuml CI (#404)
Browse files Browse the repository at this point in the history
We will enable this again once cuml's tests are passing w/ the changes.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #404
  • Loading branch information
cjnolet authored Dec 2, 2021
1 parent 6e46e67 commit 80507ee
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions cpp/include/raft/spatial/knn/detail/knn_brute_force_faiss.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,13 @@ void brute_force_knn_impl(

cudaStream_t stream = raft::select_stream(userStream, internalStreams, n_int_streams, i);

// TODO: Enable this once we figure out why it's causing pytest failures in cuml.
if (k <= 64 && rowMajorQuery == rowMajorIndex && rowMajorQuery == true &&
(metric == raft::distance::DistanceType::L2Unexpanded ||
metric == raft::distance::DistanceType::L2SqrtUnexpanded ||
metric == raft::distance::DistanceType::L2Expanded ||
metric == raft::distance::DistanceType::L2SqrtExpanded)) {
metric == raft::distance::DistanceType::L2SqrtUnexpanded //||
// metric == raft::distance::DistanceType::L2Expanded ||
// metric == raft::distance::DistanceType::L2SqrtExpanded)
)) {
fusedL2Knn(D,
out_i_ptr,
out_d_ptr,
Expand Down

0 comments on commit 80507ee

Please sign in to comment.