Skip to content

Commit

Permalink
Add TODO about using mdbuffer
Browse files Browse the repository at this point in the history
  • Loading branch information
benfred committed Sep 5, 2023
1 parent 0e0c5f3 commit 6552c66
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cpp/include/raft/neighbors/detail/cagra/utils.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ struct gen_index_msb_1_mask {
* if the host_matrix_view is already accessible on the device, and only creates device
* memory and copies over if necessary. In memory limited situations this is preferable
* to having both a host and device copy
* TODO: once the mdbuffer changes here https://github.com/wphicks/raft/blob/fea-mdbuffer
* have been merged, we should remove this class and switch over to using mdbuffer for this
*/
template <typename T, typename IdxT>
class device_matrix_view_from_host {
Expand Down Expand Up @@ -205,6 +207,8 @@ class device_matrix_view_from_host {
* if the device_matrix_view is already accessible on the host, and only creates host
* memory and copies over if necessary. In memory limited situations this is preferable
* to having both a host and device copy
* TODO: once the mdbuffer changes here https://github.com/wphicks/raft/blob/fea-mdbuffer
* have been merged, we should remove this class and switch over to using mdbuffer for this
*/
template <typename T, typename IdxT>
class host_matrix_view_from_device {
Expand Down

0 comments on commit 6552c66

Please sign in to comment.