Skip to content

Commit

Permalink
Reduce NN Descent test threshold (#1946)
Browse files Browse the repository at this point in the history
Recently we have been noticing intermittent nightly failures in NN Descent tests that appear even when increasing the number of iterations. This is believed to be a result of non-determinism in the algorithm itself rather than a result of stochasticity, and so it cannot be seeded out. This PR attempts to fix the intermittent failures by slightly reducing the threshold.

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1946
  • Loading branch information
divyegala authored Oct 31, 2023
1 parent f720605 commit 4035534
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/test/neighbors/ann_nn_descent.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,6 @@ const std::vector<AnnNNDescentInputs> inputs = raft::util::itertools::product<An
{32, 64}, // graph_degree
{raft::distance::DistanceType::L2Expanded},
{false, true},
{0.92});
{0.90});

} // namespace raft::neighbors::experimental::nn_descent

0 comments on commit 4035534

Please sign in to comment.