Relax cuda-version constraint
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `{{ compiler('cuda') }}`, it adds a `cuda-version` constraint
lower bound based on the version it built with to the package. However
this conflicts with the intended usage of this package and the
`cuda-version` constraint this package adds itself. So ignore the
constraint added by `{{ compiler('cuda') }}`.
|
This came up here ( rapidsai/cudf#14763 (comment) ) cc @brandon-b-miller (for awareness) |
Merged
brandon-b-miller
approved these changes
Jan 16, 2024
bdice
approved these changes
Jan 16, 2024
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
{{ compiler('cuda') }}, it adds acuda-versionconstraint lower bound based on the version it built with to the package. However this conflicts with the intended usage of this package and thecuda-versionconstraint this package adds itself. So ignore the constraint added by{{ compiler('cuda') }}.