Skip to content

Commit

Permalink
make conda recipe data-loading stricter (#90)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#72.

Proposes replacing a use of `.get()` in the conda recipe with `[]`, to
ensure that we get a loud build error if the `"project"` table is not
present when `conda-build` reads `pyproject.toml`.

## Notes for Reviewers

I know that at some time in the past, the `.get()` was introduced as a
possible solution for errors observed at build time:
#33 (comment)

Pushed this to see if those issues are still present, and they don't
seem to be!
  • Loading branch information
jameslamb authored Jun 13, 2024
1 parent 5e0dc9c commit fe2ed0c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion conda/recipes/pynvjitlink/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
load_file="pynvjitlink/VERSION",
regex_pattern="(?P<value>.*)"
)[0] %}
{% set project_data = data.get("project") %}
{% set project_data = data["project"] %}
{% set project_urls = project_data["urls"] %}

package:
Expand Down

0 comments on commit fe2ed0c

Please sign in to comment.