Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --batch mode from verify-copyright #15

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

The behavior of --batch mode is not consistent with the default PR mode in terms of determining whether or not a file has been modified, and that creates problems when trying to use --batch mode followed by PR mode. The approach of "eventual consistency" seems good enough for now.

The behavior of --batch mode is not consistent with the default PR
mode in terms of determining whether or not a file has been modified,
and that creates problems when trying to use --batch mode followed
by PR mode. The approach of "eventual consistency" seems good enough
for now.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner January 30, 2024 16:40
@KyleFromNVIDIA KyleFromNVIDIA merged commit 42554b7 into rapidsai:main Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants