Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secrets handling #200

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Update secrets handling #200

merged 11 commits into from
Jan 23, 2025

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Jan 9, 2025

  • Fixes the secret vulnerability mentioned by AJ here
  • Upgrades the Node version from 18 to 22
  • Upgrades probot version
  • Converts the build system to use esbuild, reducing build size and time, and so we don't have to upload node_modules to Lambda (which has an upload size limit for deployed code)
    • build size goes from ~48MB for each function to ~3MB

Note to Reviewers:

  • I have tested by deploying the latest commit of this PR during off-hours from my local machine. This is still the currently active ops-bot deployment.
  • This was potentially the only real way to test it seeing the major change in this PR is interacting with AWS Secrets Manager during start up to fetch needed secrets. Testing by deploying to AWS would ensure that we confirm that the lambda function could retreive these secrets.
  • Forward merger test PR: https://github.com/rapidsai/literate-octo-potato/pull/888

Current lambda deployment screenshot (merging this PR should produce the same state in AWS shown below):
Screenshot 2025-01-20 at 10 01 42 AM

@AyodeAwe AyodeAwe mentioned this pull request Jan 10, 2025
@AyodeAwe AyodeAwe marked this pull request as ready for review January 20, 2025 22:10
@AyodeAwe AyodeAwe changed the title Fix secret vuln Update secrets handling Jan 21, 2025
@AyodeAwe AyodeAwe merged commit 79a27e5 into main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants