Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip PR template in merge commit message #102

Closed
karthikeyann opened this issue May 3, 2022 · 0 comments · Fixed by #103
Closed

strip PR template in merge commit message #102

karthikeyann opened this issue May 3, 2022 · 0 comments · Fixed by #103

Comments

@karthikeyann
Copy link
Contributor

karthikeyann commented May 3, 2022

PR template with checklist and additional text helps authors to create better PRs. e.g. PR template is updated in PR rapidsai/cudf#10774
@gpucibot merge uses PR description text as commit message verbatim. but this template text need not be present in commit message.

Add some preprocessing to strip off PR template from PR description text before using it as commit message.
more discussion here rapidsai/cudf#10774 (comment) and https://nvidia.slack.com/archives/CALTSAKJ6/p1651590453510599?thread_ts=1651582344.289729&cid=CALTSAKJ6

karthikeyann added a commit to karthikeyann/ops-bot that referenced this issue May 6, 2022
extracts text in "## description" section and skips text after "## checklist".
Request from rapidsai#102
ajschmidt8 added a commit that referenced this issue Jul 12, 2022
* extract description from PR body text

extracts text in "## description" section and skips text after "## checklist".
Request from #102

* fix this reference

* add unit test for PR body text extraction

* change pulls_get.json to pulls_get.ts

* update auto_merger tests

* formatting updates

Co-authored-by: Karthikeyan Natarajan <[email protected]>
Co-authored-by: AJ Schmidt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant