-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bipartite Betweenness Centrality #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always makes me nervous when things "just work" on the first try 😂, but this all looks good to me, including 100% coverage of the new function.
We could consider adding k=
and seed=
as extra parameters or upstream to networkx (better than extra parameters), but I think it's probably okay to wait until somebody asks for them.
Co-authored-by: Erik Welch <[email protected]>
I added a basic benchmark using a random graph. Running on my desktop (I don't know how it compares to other machines):
For nx-cugraph, >99% of the time is spent in |
Companion PR that updates docs: rapidsai/cugraph#4778 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enchmarks looks good.
/merge |
…ithms (#4778) Update docs once rapidsai/nx-cugraph#32 is merged.
This PR adds
bipartite
>betweenness_centrality
to nx-cugraph (seen here in NetworkX)This was a combined effort with @eriknw to get myself familiarized with adding new algorithms.