Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce wheel size limits, README formatting in CI #19

Merged
merged 4 commits into from
Nov 15, 2024
Merged

enforce wheel size limits, README formatting in CI #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50d4b19
enforce wheel size limits, README formatting in CI
jameslamb Nov 13, 2024
fdca5bd
Merge branch 'branch-24.12' into wheel-validation
jameslamb Nov 13, 2024
76093e5
Merge branch 'branch-24.12' into wheel-validation
jameslamb Nov 14, 2024
d972476
Merge branch 'wheel-validation' of github.com:jameslamb/nx-cugraph in…
jameslamb Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/build_wheel_nx-cugraph.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@

set -euo pipefail

# pkg-name pkg-dir
./ci/build_wheel.sh nx-cugraph .
./ci/validate_wheel.sh dist
18 changes: 18 additions & 0 deletions ci/validate_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/bin/bash
# Copyright (c) 2024, NVIDIA CORPORATION.

set -euo pipefail

wheel_dir_relative_path=$1

rapids-logger "validate packages with 'pydistcheck'"

pydistcheck \
--inspect \
"$(echo ${wheel_dir_relative_path}/*.whl)"

rapids-logger "validate packages with 'twine'"

twine check \
--strict \
"$(echo ${wheel_dir_relative_path}/*.whl)"
8 changes: 8 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ exclude_lines = [
"raise NotImplementedError",
]

[tool.pydistcheck]
select = [
"distro-too-large-compressed",
]

# PyPI limit is 100 MiB, fail CI before we get too close to that
max_allowed_size_compressed = '75M'

[tool.ruff]
# https://github.com/charliermarsh/ruff/
line-length = 88
Expand Down
Loading