add CI workflows running tests #15
Conversation
Signed-off-by: James Lamb <[email protected]>
jameslamb
added
improvement
| commit-files = ["_nx_cugraph/GIT_COMMIT"] | ||
| dependencies-file = "../../dependencies.yaml" | ||
| commit-files = ["nx_cugraph/GIT_COMMIT"] | ||
| dependencies-file = "dependencies.yaml" |
There was a problem hiding this comment.
Wheel tests were failing like this:
ERROR: Could not find a version that satisfies the requirement pylibcugraph==24.12.*,>=0.0.0a0 (from nx-cugraph-cu12) (from versions: none)
That's because the wheel builds were not correctly setting metadata about what packages nx-cugraph depends on. rapids-build-backend was warning but not failing here:
/pyenv/versions/3.12.7/lib/python3.12/contextlib.py:137: UserWarning: File not found: '../../dependencies.yaml'. If you want rapids-build-backend to consider dependencies from a dependencies file, supply an existing file via config setting 'dependencies-file'.
For background, it was an intentional choice to make that case a warning instead of an error: rapidsai/rapids-build-backend#33 (comment)
jameslamb
changed the title
jameslamb
changed the title
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python | ||
| with: | ||
| build_type: pull-request | ||
| run_codecov: false |
There was a problem hiding this comment.
Saw codecov upload failing like this:
error - 2024-11-08 16:32:44,232 -- Commit creating failed: {"message":"Repository not found"}
Maybe this repo needs to be set up in the codecov UI. But since @eriknw mentioned that codecov isn't really event being used in development of this project right now, I'm proposing just skipping it.
jameslamb
changed the title
|
/merge |
`_nxver` was updated to either be a 2-tuple or 3-tuple in #15, and we needed to update some comparisons to properly handle nx 3.4.1 and nx 3.4.2. The new pre-commit enforces sane comparisons when using `_nxver`. Authors: - Erik Welch (https://github.com/eriknw) - Rick Ratzel (https://github.com/rlratzel) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Jake Awe (https://github.com/AyodeAwe) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #22
Closes https://github.com/rapidsai/graph_dl/issues/638
Adds CI workflows running the unit tests.
Also adds some
.pre-commit-config.yamlchanges, follow-up to #14 suggested by @eriknw .Notes for Reviewers
I copied these new scripts in
ci/from the latest state ofbranch-24.12in https://github.com/rapidsai/cugraph, then tried to adapt them to benx-cugraphspecific.What about notebook tests?
Proposing we add notebook tests in a follow-up PR, to keep things smaller and easier to review.