Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system fixes #130

Merged
merged 12 commits into from
Mar 23, 2021
Merged

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented Mar 23, 2021

  • Fix discrepancies in CMake CUDA architecture selection when configure/build are done separately
  • Fix ccache's base_dir to point to the repo root so ccache can handle the node-addon-api include paths in <root>/node_modules
  • Set PARALLEL_LEVEL=1 as default when building, use dotenv to read .env file for custom env overrides
  • Use common build directories for CPM dependencies, so cuDF/cuGraph/cuSpatial bindings don't all end up recompiling cuDF
  • Updates branches for libcudf/libcuspatial to take advantage of compile-time optimizations for a smaller libcudf.so

Branched from #128

@trxcllnt trxcllnt requested review from bryevdv and AjayThorve March 23, 2021 03:57
@trxcllnt trxcllnt added the enhancement New feature or request label Mar 23, 2021
@bryevdv
Copy link
Contributor

bryevdv commented Mar 23, 2021

LGTM but merging the other PR left some small conflicts :/

@trxcllnt trxcllnt merged commit 760f279 into rapidsai:main Mar 23, 2021
@trxcllnt trxcllnt deleted the fea/common-deps-build-dirs branch March 23, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants