Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark detail functions as inline #69

Merged
merged 3 commits into from
May 5, 2022
Merged

Mark detail functions as inline #69

merged 3 commits into from
May 5, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 5, 2022 •
edited
Loading

These function needs to be inline so that the header can be safely included in multiple files in the same TU without ODR violations.

@vyasr vyasr self-assigned this May 5, 2022
@vyasr vyasr added bug Something isn't working non-breaking Introduces a non-breaking change c++ Affects the C++ API of KvikIO labels May 5, 2022
@vyasr vyasr marked this pull request as draft May 5, 2022 17:37
@vyasr vyasr changed the title Make open_flags inline Mark detail functions as inline May 5, 2022
@vyasr vyasr marked this pull request as ready for review May 5, 2022 17:43
madsbk
madsbk approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyasr for the quick fix!
I have added some more missing inlines :)

@hyperbolic2346 hyperbolic2346 mentioned this pull request May 5, 2022
Merged
@vyasr
Copy link
Contributor Author

vyasr commented May 5, 2022 •
edited
Loading

Thanks @vyasr for the quick fix! I have added some more missing inlines :)

Thanks, I only caught the ones that are in files that cudf is actually including right now!

@vyasr
Copy link
Contributor Author

vyasr commented May 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e220128 into rapidsai:branch-22.06 May 5, 2022
@jlowe jlowe mentioned this pull request May 5, 2022
Merged
vuule pushed a commit to vuule/kvikio that referenced this pull request Nov 8, 2023
@mroeschke
Allow empty, dtyped IntervalIndex input to keep dtype (rapidsai#69)
f1564a8 
Before, this would always default to int64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@madsbk madsbk madsbk approved these changes

Assignees

@vyasr vyasr

Labels
bug Something isn't working c++ Affects the C++ API of KvikIO non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @madsbk @hyperbolic2346