Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert_size2off(): fix different signedness #60

Merged
merged 2 commits into from
Apr 22, 2022
Merged

convert_size2off(): fix different signedness #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaba165
cmake-basic-example: adding the -Werror compile flag
madsbk Apr 22, 2022
53c9b56
convert_size2off(): fix different signedness
madsbk Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cpp/examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,10 @@
add_executable(basic_io basic_io.cpp)
target_include_directories(basic_io PRIVATE ../include ${cuFile_INCLUDE_DIRS})
target_link_libraries(basic_io PRIVATE kvikio CUDA::cudart)

if(CMAKE_COMPILER_IS_GNUCXX)
set(KVIKIO_CXX_FLAGS "-Wall;-Werror;-Wno-unknown-pragmas")
target_compile_options(
basic_io PRIVATE "$<$<COMPILE_LANGUAGE:CXX>:${KVIKIO_CXX_FLAGS}>"
)
endif()
2 changes: 1 addition & 1 deletion cpp/include/kvikio/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ inline constexpr std::size_t page_size = 4096;

[[nodiscard]] inline off_t convert_size2off(std::size_t x)
{
if (x >= std::numeric_limits<off_t>::max()) {
if (x >= static_cast<std::size_t>(std::numeric_limits<off_t>::max())) {
throw CUfileException("size_t argument too large to fit off_t");
}
return static_cast<off_t>(x);
Expand Down