Use curl >=8.5.0 to align with conda-forge and avoid CVEs. #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raydouglass
approved these changes
Dec 9, 2024
jakirkham
reviewed
Dec 9, 2024
Co-authored-by: jakirkham <[email protected]>
vyasr
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Looks fine to me.
Leaving some notes for posterity:
- The conda run exports are overly strict because libcurl has been ABI-stable since 7.16.0, so building against 7.* and running with 8.* is fine.
- For conda, we shouldn't really need to bump the build version for CVE reasons since we could simply relax the run_exported constraint above and be fine. It's not really worthwhile though since the conda-forge pinning is already at 8.
- For wheels, for CVE reasons we definitely need to bump the build version in addition to runtime constraints because we statically link libcurl into wheels so the build version entirely controls runtime behavior.
Please feel free to raise a feedstock issue (though am not sure to what extent the 7 series is still supported) Edit: We could also use |
madsbk
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
libcurl8.5.0 at build time, and should permit>=8.5.0,<9.0a0at runtime. This is needed to align with conda-forge which useslibcurl8, and also gets a new enough minor version to avoid some known CVEs.