Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nvcomp to 4.1.1.1 #568

Closed
wants to merge 3 commits into from
Closed

Upgrade nvcomp to 4.1.1.1 #568

wants to merge 3 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 5, 2024 •
edited
Loading

This updates kvikio to use nvcomp 4.1.1.1. This includes some bug fixes needed for Spark-RAPIDS.

The version is updated in rapids-cmake in rapidsai/rapids-cmake#727.

@bdice bdice requested a review from a team as a code owner December 5, 2024 03:04
@bdice bdice requested a review from raydouglass December 5, 2024 03:04
@bdice bdice requested a review from a team as a code owner December 5, 2024 03:06
@bdice bdice added feature request New feature or request non-breaking Introduces a non-breaking change labels Dec 5, 2024
@bdice bdice self-assigned this Dec 5, 2024
@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Are we able to use a looser pinning for this dependency? Think that would make it easier to update (and for users to install)

@bdice
Copy link
Contributor Author

bdice commented Dec 5, 2024 •
edited
Loading

Are we able to use a looser pinning for this dependency?

No, unfortunately. We require this to match rapids-cmake's pinnings exactly, and to ensure that we get bug fixes in the latest release. Eventually it would be nice to expand our range of nvcomp versions we allow, but we have been pinned at "latest" for a long time due to the requirement of matching rapids-cmake, in addition to many API/ABI breaking changes and required bug fixes in each new release of nvcomp. Things are getting more stable over time, so this may be revisited in the medium/long term.

@jakirkham
Copy link
Member

Ok happy to punt

Though let's see if we can find a simpler update path: rapidsai/build-planning#125

@jakirkham
Copy link
Member

Looks like the wheels are not on PyPI yet. Hence those CI jobs fail

jakirkham
jakirkham approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Approving as these look like the changes we want

We can restart CI when the remaining packages are uploaded

@bdice
Copy link
Contributor Author

bdice commented Dec 6, 2024

Retargeting to 25.02.

@bdice bdice changed the base branch from branch-24.12 to branch-25.02 December 6, 2024 18:44
@bdice
Copy link
Contributor Author

bdice commented Dec 11, 2024

After discussion with @sameerz, I think we can hold off on taking this update. We may take a different nvcomp release in 25.02.

@bdice bdice closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@bdice bdice

Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @jakirkham @madsbk