Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport FindCUDAToolkit from CMake 3.31 #550

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

Backport to get
https://gitlab.kitware.com/cmake/cmake/-/commit/b38a8e77cb3c8401b3022a68f07a4fd77b290524, so that find_library() finds libcufile correctly.

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners November 14, 2024 16:39
@KyleFromNVIDIA KyleFromNVIDIA requested a review from bdice November 14, 2024 16:39
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 14, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to copy in a license file before we can vendor CMake code directly like this?

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3f66927 into rapidsai:branch-24.12 Nov 15, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants